chore(ec2): add missing interface VPC endpoint services#21220
Conversation
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
We'll need some sort of tests with this change. Additionally, please see the Pull Request section of our Contributing Guide regarding our guidelines to PR body text.
|
Given that this PR only adds some static variables to an existing enum without tests, I would love some feedback on what the tests should include. I will update the PR description. |
We have a lot of areas where our test coverage isn't what it should be. We use any opportunity we can get to improve test coverage. Basically, we want to ensure that use of these values creates the template output we'd expect. So, please write tests that use these in a construct and ensure that the template matches your expected values. If you need examples of where we've tested against templates, please let me know. |
…21401) This add the following endpoints to `InterfaceVpcEndpointAwsService`: `codeartifact.api` `codeartifact.respositories` `batch` `autoscaling` `autoscaling-plan` `application-autoscaling` closes #21402 #21220 #21338 #19420 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Closing since #21401 has been merged. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license