Skip to content

docs: update documentation for custom resources#21202

Merged
mergify[bot] merged 4 commits intomainfrom
huijbers/custom-resource-docs
Jul 19, 2022
Merged

docs: update documentation for custom resources#21202
mergify[bot] merged 4 commits intomainfrom
huijbers/custom-resource-docs

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jul 18, 2022

Be more clear about what we recommend people do and do not use,
and be very clear that even though the Custom Resource Provider
Framework's handlers look a lot like CloudFormation Custom Resource
handlers, they are actually different.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Be more clear about what we recommend people do and do not use,
and be very clear that even though the Custom Resource Provider
Framework's handlers look a lot like CloudFormation Custom Resource
handlers, they are actually different.
@rix0rrr rix0rrr requested a review from a team July 18, 2022 12:38
@rix0rrr rix0rrr self-assigned this Jul 18, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 18, 2022

@github-actions github-actions bot added the p2 label Jul 18, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2022 12:39
@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

Why is this failing on an appsync test?

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Jul 18, 2022

I saw the fix for appsync so I merged that in but now it's failing on something else. ¯\_(ツ)_/¯

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e8c9461
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2b846f1 into main Jul 19, 2022
@mergify mergify bot deleted the huijbers/custom-resource-docs branch July 19, 2022 13:42
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
Be more clear about what we recommend people do and do not use,
and be very clear that even though the Custom Resource Provider
Framework's handlers look a lot like CloudFormation Custom Resource
handlers, they are actually different.


----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants