Skip to content

fix(cli): pin geonamescache dependency to 1.3#21152

Merged
mergify[bot] merged 4 commits intov1-mainfrom
conroy/pin
Jul 15, 2022
Merged

fix(cli): pin geonamescache dependency to 1.3#21152
mergify[bot] merged 4 commits intov1-mainfrom
conroy/pin

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Jul 15, 2022

Our integ tests are failing because geonamescache recently released v1.4 and we are hardcoding v1.3 in our cli tests. This is currently blocking CDK v1.164.0's release, which has a p0 fix, so I'm simply pinning the dependency and we can worry about any potentially better solutions later.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 15, 2022

@github-actions github-actions bot added the p2 label Jul 15, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 15, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 15, 2022 00:20
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Jul 15, 2022
@kaizencc
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport main

@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Jul 15, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2022

backport main

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 25329c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 10f4304 into v1-main Jul 15, 2022
@mergify mergify bot deleted the conroy/pin branch July 15, 2022 02:42
mergify bot pushed a commit that referenced this pull request Jul 15, 2022
Our integ tests are failing because geonamescache recently [released](https://github.com/aws/aws-cdk/pull/21152/files) v1.4 and we are hardcoding v1.3 in our cli tests. This is currently blocking CDK v1.164.0's release, which has a p0 fix, so I'm simply pinning the dependency and we can worry about any potentially better solutions later.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit 10f4304)
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2022

backport main

✅ Backports have been created

Details

mergify bot added a commit that referenced this pull request Jul 15, 2022
This is an automatic backport of pull request #21152 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
kaizencc pushed a commit that referenced this pull request Jul 15, 2022
This is an automatic backport of pull request #21152 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
…ws#21157)

This is an automatic backport of pull request aws#21152 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
@HBobertz HBobertz mentioned this pull request Nov 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants