Skip to content

chore(s3-deployments): update python version on BucketDeployment handler to python 3.9#21148

Merged
mergify[bot] merged 5 commits intomainfrom
conroy/python39
Aug 3, 2022
Merged

chore(s3-deployments): update python version on BucketDeployment handler to python 3.9#21148
mergify[bot] merged 5 commits intomainfrom
conroy/python39

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

Only 1 actual line of code changed in bucket-deployment.ts. Everything else is a result of yarn integ-runner --update-on-failed


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 14, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 14, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2022 19:54
@github-actions github-actions bot added the p2 label Jul 14, 2022
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 15, 2022

@kaizencc How do we test if that change doesn't break the CR?

@Naumel
Copy link
Copy Markdown
Contributor

Naumel commented Jul 15, 2022

@aws-cdk/aws-ecs:   CHANGED    ec2/integ.environment-file 3.684s
@aws-cdk/aws-ecs:       Resources
@aws-cdk/aws-ecs: [~] AWS::Lambda::Function CustomCDKBucketDeployment8693BB64968944B69AAFB0CC9EB8756C81C01536 
@aws-cdk/aws-ecs:  └─ [~] Runtime
@aws-cdk/aws-ecs:      ├─ [-] python3.7
@aws-cdk/aws-ecs:      └─ [+] python3.9
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.capacity-providers 2.532s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.add-environment-variable 2.676s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.exec-command 2.683s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.fargate-with-efs 2.616s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.firelens-cloudwatch 2.709s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.lb-awsvpc-nw 2.725s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.secret 2.536s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.nlb-awsvpc-nw 2.762s
@aws-cdk/aws-ecs:   UNCHANGED  fargate/integ.runtime 2.832s
@aws-cdk/aws-ecs: Snapshot Results: 
@aws-cdk/aws-ecs: Tests:    1 failed, 25 total
@aws-cdk/aws-ecs: Error: Some tests failed!

Are there changes that did not make it in the commit(s) ?

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2022

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 371f5ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f7a65ea into main Aug 3, 2022
@mergify mergify bot deleted the conroy/python39 branch August 3, 2022 06:16
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

rajyan added a commit to rajyan/low-cost-ecs that referenced this pull request Aug 29, 2022
…ated lambda for deleting resources requires python >= 3.9
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
----

related to #21148

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants