Skip to content

chore(merge-back): 2.31.2#21133

Merged
mergify[bot] merged 6 commits intomainfrom
merge-back/2.31.2
Jul 14, 2022
Merged

chore(merge-back): 2.31.2#21133
mergify[bot] merged 6 commits intomainfrom
merge-back/2.31.2

Conversation

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jul 14, 2022

See CHANGELOG

mrgrain and others added 5 commits July 13, 2022 16:12
… `ResponseURL` to user function (#21117)

#20889 included a change that broke the custom resource framework by not including the necessary presigned URL. We attempted to fix this with #21065 but it didn't resolve the issue and #21109 reverted the attempted fix.

This changes explicitly includes the presigned URL, as well as adding tests to ensure the URL is passed to the downstream Lambda Function.

Closes #21058

----

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Jul 14, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 14, 2022

@github-actions github-actions bot added the p2 label Jul 14, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2022 01:43
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b085819
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f5010e2 into main Jul 14, 2022
@mergify mergify bot deleted the merge-back/2.31.2 branch July 14, 2022 05:08
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve p2 pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants