fix(core): updatedProperties function name is misspelled#21071
fix(core): updatedProperties function name is misspelled#21071mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
|
|
|
My apologies. Perhaps this fix affects more places than I realize? |
kaizencc
left a comment
There was a problem hiding this comment.
Oh gosh. Thanks for finding this and bringing it to our attention. I'm not sure we can do this because it is a breaking change. What we have to do is deprecate updatedProperites and introduce a new updatedProperties method that does the same thing. @michimani is this something you're interested in doing?
|
Thank you for confirming this. |
|
Excuse my repeated comments. |
4b69581 to
0ae0f26
Compare
0ae0f26 to
1c5578e
Compare
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Looks good! Thanks for catching this!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…21144) Makes sure that we don't have two separate implementations for the same thing, so point the misspelled `updatedProperites` to the correct `updatedProperties`. See: #21071. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ws#21144) Makes sure that we don't have two separate implementations for the same thing, so point the misspelled `updatedProperites` to the correct `updatedProperties`. See: aws#21071. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR only fix typo in the name of protected function.
Properites->PropertiesAll Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license