fix(aws-ec2): flow log destinationOptions requires all properties#21042
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Jul 7, 2022
corymhall:corymhall/aws-ec2/fix-flow-logs
Merged
fix(aws-ec2): flow log destinationOptions requires all properties#21042mergify[bot] merged 2 commits intoaws:mainfrom corymhall:corymhall/aws-ec2/fix-flow-logs
mergify[bot] merged 2 commits intoaws:mainfrom
corymhall:corymhall/aws-ec2/fix-flow-logs
Conversation
PR #20765 introduced destinationOptions, but only introduced one of the optional properties ('hiveCompatiblePartitions') since that is the only property that was relevant for the PR. The [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-flowlog.html#cfn-ec2-flowlog-destinationoptions) don't specify this, but if you provide `destinationOptions` you must specify a value for each prop, otherwise you will receive an error message on deploy. This PR adds the two additional properties. re #21037
|
|
TheRealAmazonKendra
approved these changes
Jul 7, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…s#21042) PR aws#20765 introduced destinationOptions, but only introduced one of the optional properties ('hiveCompatiblePartitions') since that is the only property that was relevant for the PR. The [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-flowlog.html#cfn-ec2-flowlog-destinationoptions) don't specify this, but if you provide `destinationOptions` you must specify a value for each prop, otherwise you will receive an error message on deploy. This PR adds the two additional properties. re aws#21037 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #20765 introduced destinationOptions, but only introduced one of the
optional properties ('hiveCompatiblePartitions') since that is the only
property that was relevant for the PR. The docs
don't specify this, but if you provide
destinationOptionsyou mustspecify a value for each prop, otherwise you will receive an error
message on deploy.
This PR adds the two additional properties.
re #21037
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license