chore: update F# template for new addSubscription signature#21038
Merged
mergify[bot] merged 2 commits intomainfrom Jul 7, 2022
Merged
chore: update F# template for new addSubscription signature#21038mergify[bot] merged 2 commits intomainfrom
addSubscription signature#21038mergify[bot] merged 2 commits intomainfrom
Conversation
Our build currently breaks because the F# template assumes that `addSubscription` returns `void`, which we recently changed. Ignore the return value of the function instead.
|
|
TheRealAmazonKendra
approved these changes
Jul 7, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
) Our build currently breaks because the F# template assumes that `addSubscription` returns `void`, which we recently changed. Ignore the return value of the function instead. Given the choice between: ``` topic.AddSubscription(SqsSubscription(queue)) |> ignore ignore topic.AddSubscription(SqsSubscription(queue)) ``` Went with the first, the second reads a little dismissive :) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Our build currently breaks because the F# template assumes that addSubscription returns void, which we recently changed. #21038 tried to solve this, but the build failed with a different error. I ran this change through our test pipeline, which succeeded. That is the only reason why I am at all confident in this change. Mostly flying blind in F#... ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our build currently breaks because the F# template assumes that
addSubscriptionreturnsvoid, which we recently changed.Ignore the return value of the function instead.
Given the choice between:
Went with the first, the second reads a little dismissive :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license