chore(init-templates): remove v1 init templates#21019
Conversation
|
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio unqueue |
✅ The pull request has been removed from the queue |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
1133950 to
1745927
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
A v1 app or library cannot be created from the v2 cli. This cleans up the v1 init template code.
1745927 to
8147860
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
A v1 app or library cannot be created from the v2 cli. This cleans up the v1 init template code.
This is stupidly long because of the amount of files deleted and moved so here's a rundown of the changes:
- v1 templates deleted (github is showing some of these as renamed because they were duplicates of the v2 files that did get moved)
- v2 templates removed from `v2` folder and moved directly under `init-templates`
- hook files imports updated (another place where it shows the change to v1 instead of v2 because the contents were the same) for templates and sample apps
- `init.ts`: updated file paths to flattened directory
- `init.test.ts`:
- updated tests to only run for v2 templates
- added test for `fsharp` since it was missing
- updated .NET tests to look in the contents of the `.sln` file for the project information. I noticed that this test sometimes still passed when the `init` actually failed.
Note: This is the first of two PRs to fix the bug for creating .NET projects with spaces in the file path (issue #18803). This PR was done separately so the bug fix didn't get lost in the 300 file changes due to the cleanup.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
A v1 app or library cannot be created from the v2 cli. This cleans up the v1 init template code.
This is stupidly long because of the amount of files deleted and moved so here's a rundown of the changes:
v2folder and moved directly underinit-templatesinit.ts: updated file paths to flattened directoryinit.test.ts:fsharpsince it was missing.slnfile for the project information. I noticed that this test sometimes still passed when theinitactually failed.Note: This is the first of two PRs to fix the bug for creating .NET projects with spaces in the file path (issue aws/aws-cdk-cli#683). This PR was done separately so the bug fix didn't get lost in the 300 file changes due to the cleanup.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license