Skip to content

docs: explain procedure for rotating a SecretsManager Secret#20989

Merged
mergify[bot] merged 3 commits intomainfrom
huijbers/explain-secret-rotation
Jul 5, 2022
Merged

docs: explain procedure for rotating a SecretsManager Secret#20989
mergify[bot] merged 3 commits intomainfrom
huijbers/explain-secret-rotation

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jul 4, 2022

CloudFormation will not automatically check all Secrets for their
values, so it is up to the user to incude a change in the resource
that uses a Secret, so that CloudFormation will re-read the value.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

CloudFormation will not automatically check all Secrets for their
values, so it is up to the user to incude a change in the resource
that uses a Secret, so that CloudFormation will re-read the value.
@rix0rrr rix0rrr requested a review from a team July 4, 2022 16:01
@rix0rrr rix0rrr self-assigned this Jul 4, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 4, 2022

@github-actions github-actions bot added the p2 label Jul 4, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 4, 2022 16:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 4, 2022
Copy link
Copy Markdown
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e154dc0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 5, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ffd3d2d into main Jul 5, 2022
@mergify mergify bot deleted the huijbers/explain-secret-rotation branch July 5, 2022 10:26
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
CloudFormation will not automatically check all Secrets for their
values, so it is up to the user to incude a change in the resource
that uses a Secret, so that CloudFormation will re-read the value.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants