Skip to content

docs: fix wrong annotation used in example#20964

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
GuyDev1:patch-2
Jul 5, 2022
Merged

docs: fix wrong annotation used in example#20964
mergify[bot] merged 2 commits intoaws:mainfrom
GuyDev1:patch-2

Conversation

@GuyDev1
Copy link
Copy Markdown
Contributor

@GuyDev1 GuyDev1 commented Jul 2, 2022

Used a misleading @mutating annotation instead of a @config annotation.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Used a misleading @mutating annotation instead of a @config annotation.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2022 11:45
@github-actions github-actions bot added the p2 label Jul 2, 2022
@kaizencc kaizencc changed the title Fix wrong annotation used in example docs: fix wrong annotation used in example Jul 5, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 5, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ab0083a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e274edc into aws:main Jul 5, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 5, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Used a misleading `@mutating` annotation instead of a `@config` annotation.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants