Conversation
|
|
| * `fix`: indicates a bug fixes (requires tests) | ||
| * `docs`: indicates updated documentation (docstrings or Markdown files) | ||
| * `refactor`: indicates a feature-preserving refactoring | ||
| * `chore`: something without directly visible user benefit (does not end up in the CHANGELOG). Typically used for build scripts, config, or changes so minor they don't warrant showing up the CHANGELOG. |
There was a problem hiding this comment.
| * `chore`: something without directly visible user benefit (does not end up in the CHANGELOG). Typically used for build scripts, config, or changes so minor they don't warrant showing up the CHANGELOG. | |
| * `chore`: something without directly visible user benefit (does not end up in the CHANGELOG). Typically used for build scripts or config changes. |
I think "minor" changes leaves too much open to interpretation. I think if there is any functionality change, no matter how "minor", it should not be a chore.
There was a problem hiding this comment.
I'm not sure. New enum members for example, or a property that should always have been there but wasn't. I mean I guess technically they are features, but it feels a little like scraping the bottom of the barrel to me to put that up in the CHANGELOG. As in, I would feel ashamed putting it there 🫣
There was a problem hiding this comment.
Properties that should have been there like these? I feel like it's better to default to being less ambiguous. Core members can always change it to chore before approving if they really don't want it to show up in the CHANGELOG.
aws-cdk/packages/@aws-cdk/aws-ec2/lib/launch-template.ts
Lines 621 to 655 in 6b4f92f
But if you think we should be using chore more for minor changes then I guess I'm fine with that.
CONTRIBUTING.md
Outdated
| [conventionalcommits](https://www.conventionalcommits.org). | ||
| * The title must begin with `feat(module): title`, `fix(module): title`, `refactor(module): title` or | ||
| `chore(module): title`. | ||
| * `feat`: indicates a feature added (requires tests and README updates) |
There was a problem hiding this comment.
Can we also mention that these requirements are not hard requirements and CDK maintainers have the ability to override via labels if they see fit.
I agree that people are using chore when they should be using fear to skirt these requirements, it would help to know that there are overrides in place.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license