chore(cfnspec): new libraries do not conform to pkglint#20900
Merged
mergify[bot] merged 2 commits intomainfrom Jun 30, 2022
Merged
chore(cfnspec): new libraries do not conform to pkglint#20900mergify[bot] merged 2 commits intomainfrom
mergify[bot] merged 2 commits intomainfrom
Conversation
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes #20856.
|
|
Contributor
Author
|
@Mergifyio backport v1-main |
Contributor
🟠 Waiting for conditions to matchDetails
|
Contributor
iliapolo
approved these changes
Jun 28, 2022
Contributor
|
Added |
Contributor
Author
|
I did. The other PR needs to be re-rolled. |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes #20856. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 4e52091)
Contributor
✅ Backports have been createdDetails
|
mergify bot
added a commit
that referenced
this pull request
Jun 30, 2022
) (#20927) This is an automatic backport of pull request #20900 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes aws#20856. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we updated the minimum Node version, we did not update it
in the template that is used to stamp out new construct libraries
when new CFN namespaces are added to the spec.
Meaning every cfnspec update now fails because the new packages
fail
pkglintvalidation.Update the Node version in the template.
Closes #20856.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license