feat(batch): add secrets props to job definition#20871
feat(batch): add secrets props to job definition#20871mergify[bot] merged 15 commits intoaws:mainfrom
Conversation
…s-cdk into add-batch-secrets
|
|
kaizencc
left a comment
There was a problem hiding this comment.
Hi @yoshizawa56! Is this the same PR that was previously abandoned (by us, sorry)? If so, can you link to that in the PR description as well as provide a summary of what's in this PR, also in the description. I'll make sure this one gets reviewed promptly.
kaizencc
left a comment
There was a problem hiding this comment.
@yoshizawa56 one minor thing. Otherwise this looks great!
| @@ -0,0 +1,1874 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm 90% sure that this file is not needed and shouldn't be a part of this PR. expected.json files are a relic of our legacy integration test system which are now replaced by the batch.integ.snapshot folder. I am not sure why/how this file was created, but I suspect it has something to do with the initial PR (from March) coming before we introduced the new integ system.
Can you please delete this file and then run yarn integ in your batch folder again? This file should not get created and that will verify what I'm saying is true.
There was a problem hiding this comment.
You are correct. I delete expected.json and re-ran yarn integ and it passed the test!
kaizencc
left a comment
There was a problem hiding this comment.
Awesome work @yoshizawa56! Thanks for the PR.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Add a secrets property to batch.JobDefinitionContainer. This interface is almost the same as ecs.ContainerDefinitionOptions. This is reopen PR of aws#19506 closes aws#10976 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a secrets property to batch.JobDefinitionContainer. This interface is almost the same as ecs.ContainerDefinitionOptions.
This is reopen PR of #19506
closes #10976
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license