Skip to content

fix(pipelines): 'ConfirmPermissionsBroadening' uses wrong node version#20861

Merged
mergify[bot] merged 2 commits intomainfrom
huijbers/pipelines-node-version
Jun 24, 2022
Merged

fix(pipelines): 'ConfirmPermissionsBroadening' uses wrong node version#20861
mergify[bot] merged 2 commits intomainfrom
huijbers/pipelines-node-version

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jun 24, 2022

The CodeBuild Project that is used when the ConfirmPermissionsBroadening
feature is enabled does not have a CodeBuild image specified. This
makes it use the standard:2.0 image by default, which is AL2-based
and comes with Node 12. CDK tooling now requires Node 14 to run.

Make it use the standard:5.0 image like all other CodeBuild projects,
which contains Node 14.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The CodeBuild Project that is used when the `ConfirmPermissionsBroadening`
feature is enabled does not have a CodeBuild image specified. This
makes it use the `standard:2.0` image by default, which is AL2-based
and comes with Node 12. CDK tooling now requires Node 14 to run.

Make it use the `standard:5.0` image like all other CodeBuild projects,
which contains Node 14.
@rix0rrr rix0rrr requested a review from a team June 24, 2022 16:08
@rix0rrr rix0rrr self-assigned this Jun 24, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 24, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team June 24, 2022 16:08
@github-actions github-actions bot added the p2 label Jun 24, 2022
@rix0rrr rix0rrr marked this pull request as ready for review June 24, 2022 16:08
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 24, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 36039ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 24, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bac965e into main Jun 24, 2022
@mergify mergify bot deleted the huijbers/pipelines-node-version branch June 24, 2022 16:54
MrArnoldPalmer pushed a commit that referenced this pull request Jun 24, 2022
#20861)

The CodeBuild Project that is used when the `ConfirmPermissionsBroadening`
feature is enabled does not have a CodeBuild image specified. This
makes it use the `standard:2.0` image by default, which is AL2-based
and comes with Node 12. CDK tooling now requires Node 14 to run.

Make it use the `standard:5.0` image like all other CodeBuild projects,
which contains Node 14.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
aws#20861)

The CodeBuild Project that is used when the `ConfirmPermissionsBroadening`
feature is enabled does not have a CodeBuild image specified. This
makes it use the `standard:2.0` image by default, which is AL2-based
and comes with Node 12. CDK tooling now requires Node 14 to run.

Make it use the `standard:5.0` image like all other CodeBuild projects,
which contains Node 14.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants