fix(eks): add clusterLogging props to Fargate Cluster#20707
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Jun 13, 2022
Merged
fix(eks): add clusterLogging props to Fargate Cluster#20707mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
corymhall
approved these changes
Jun 13, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
Fixes aws#19302 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
guessi
added a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
Amazon EKS Loggings was first introduced in aws#18112 and added Fargate logging support in aws#20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: aws#19898
4 tasks
guessi
added a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
Amazon EKS Loggings was first introduced in aws#18112 and added Fargate logging support in aws#20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: aws#19898
guessi
added a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
Amazon EKS Loggings was first introduced in aws#18112 and added Fargate logging support in aws#20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: aws#19898
guessi
added a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
Amazon EKS Loggings was first introduced in aws#18112 and added Fargate logging support in aws#20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: aws#19898
guessi
added a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 24, 2022
Amazon EKS Loggings was first introduced in aws#18112 and added Fargate logging support in aws#20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: aws#19898
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
…1185) ### Description Amazon EKS Loggings was first introduced in #18112 and added Fargate logging support in #20707. However, disabled loggings was not take into consideration at the very beginning of the design. With this PR, enabled clusterLogging support for enablement/disablement. Also, added test cases for no logging configured, partial logging configured, full logging configured. Fixes: #19898 ### Test Results #### Tool versions ```sh $ node --version v16.16.0 ``` ```sh $ yarn --version 1.22.19 ``` #### yarn build ```sh $ yarn build yarn run v1.22.19 $ cdk-build ... Build times for @aws-cdk/aws-eks: Total time (59.5s) | /home/ec2-user/aws-cdk/tools/@aws-cdk/cdk-build-tools/node_modules/jsii/bin/jsii (35.0s) | cfn2ts (0.6s) Done in 59.94s. ``` #### yarn test ```sh $ yarn test yarn run v1.22.19 $ cdk-test PASS test/cluster.test.js (33.488 s) PASS test/nodegroup.test.js (10.465 s) PASS test/helm-chart.test.js (5.964 s) PASS test/fargate.test.js (5.391 s) PASS test/k8s-manifest.test.js PASS test/service-account.test.js PASS test/user-data.test.js PASS test/awsauth.test.js PASS test/alb-controller.test.js PASS test/k8s-patch.test.js ... =============================== Coverage summary =============================== Statements : 93.08% ( 888/954 ) Branches : 89.47% ( 442/494 ) Functions : 94.03% ( 142/151 ) Lines : 94.83% ( 881/929 ) ================================================================================ Test Suites: 13 passed, 13 total Tests: 277 passed, 277 total Snapshots: 0 total Time: 77.227 s, estimated 91 s Ran all test suites. Verifying integration test snapshots... UNCHANGED integ.eks-oidc-provider 27.294s UNCHANGED integ.fargate-cluster 35.153s UNCHANGED integ.eks-cluster-private-endpoint 35.223s UNCHANGED integ.eks-helm-asset 35.602s UNCHANGED integ.eks-bottlerocket-ng 35.981s UNCHANGED integ.eks-cluster-handlers-vpc 36.266s UNCHANGED integ.eks-inference 36.801s UNCHANGED integ.alb-controller 37.565s UNCHANGED integ.eks-cluster 38.041s Snapshot Results: Tests: 9 passed, 9 total Tests successful. Total time (1m59.1s) | /home/ec2-user/aws-cdk/node_modules/jest/bin/jest.js (1m18.4s) | integ-runner (40.6s) Done in 119.26s. ``` #### yarn integ ```sh $ yarn integ yarn run v1.22.19 $ integ-runner Verifying integration test snapshots... UNCHANGED integ.eks-oidc-provider 25.049s UNCHANGED integ.eks-bottlerocket-ng 34.895s UNCHANGED integ.eks-cluster-private-endpoint 35.012s UNCHANGED integ.fargate-cluster 35.417s UNCHANGED integ.eks-cluster-handlers-vpc 35.563s UNCHANGED integ.eks-helm-asset 35.691s UNCHANGED integ.eks-inference 36.303s UNCHANGED integ.alb-controller 37.071s UNCHANGED integ.eks-cluster 37.843s Snapshot Results: Tests: 9 passed, 9 total Done in 40.59s. ``` ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [X] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19302
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license