Skip to content

chore(region-info): Register iso facts#20699

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
maafk:added-region-facts
Jun 10, 2022
Merged

chore(region-info): Register iso facts#20699
mergify[bot] merged 1 commit intoaws:mainfrom
maafk:added-region-facts

Conversation

@maafk
Copy link
Copy Markdown
Contributor

@maafk maafk commented Jun 10, 2022

Addition of region facts to facts table


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 10, 2022

@github-actions github-actions bot added the p2 label Jun 10, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2022 10:05
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c4200f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cgarvis
Copy link
Copy Markdown
Contributor

cgarvis commented Jun 10, 2022

@maafk maafk changed the title feat(region-info): Register iso facts chore(region-info): Register iso facts Jun 10, 2022
@maafk
Copy link
Copy Markdown
Contributor Author

maafk commented Jun 10, 2022

Could you point me to some documentation that states that these regions support ELB V2?

I don't believe there is public documentation for this. I followed up with you via private channels

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fd5808f into aws:main Jun 10, 2022
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Addition of region facts to facts table

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@maafk maafk deleted the added-region-facts branch August 8, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants