Skip to content

Add Textract support to AWS VpcEndpoint services#20604

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
J11522:feature/support-textract-vpc
Jun 13, 2022
Merged

Add Textract support to AWS VpcEndpoint services#20604
mergify[bot] merged 5 commits intoaws:mainfrom
J11522:feature/support-textract-vpc

Conversation

@J11522
Copy link
Copy Markdown
Contributor

@J11522 J11522 commented Jun 3, 2022

This change adds support for textract and textract fips to the predefined list of AWS Vpc endpoint services.
See #20586


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This change adds support for textract and textract fips to the predefined list of AWS Vpc endpoint services.
See #20586
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jun 3, 2022

@github-actions github-actions bot added the p2 label Jun 3, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2022 09:03
@corymhall
Copy link
Copy Markdown
Contributor

@J11522 I think you'll need to add an exception here for the linter

"docs-public-apis:@aws-cdk/aws-ec2.InterfaceVpcEndpointAwsService.XRAY",

@J11522
Copy link
Copy Markdown
Contributor Author

J11522 commented Jun 8, 2022

@corymhall ✅ Have added the exceptions

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0237f38
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 17ef739 into aws:main Jun 13, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
This change adds support for textract and textract fips to the predefined list of AWS Vpc endpoint services.
See aws#20586


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants