(aws-cloudwatch-actions): Add the possibility to have SSM Incident Action#20553
Closed
(aws-cloudwatch-actions): Add the possibility to have SSM Incident Action#20553
Conversation
…tion This small PR will add SSM Incident action to cloudwatch alarm. The arn format was taken from the UI console (under Incident Manager Response Plan)
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
comcalvi
suggested changes
Jun 16, 2022
Contributor
comcalvi
left a comment
There was a problem hiding this comment.
Just a few minor comments on this one.
| export * from './sns'; | ||
| export * from './ec2'; | ||
| export * from './ssm'; | ||
| export * from './ssm-incidents'; No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| export * from './ssm-incidents'; | |
| export * from './ssm-incidents'; | |
| // Create an Incident Manager incident based on a specific response plan | ||
| alarm.addAlarmAction( | ||
| new actions.SsmIncidentAction( | ||
| 'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName' | |
| 'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName', |
| @@ -0,0 +1,20 @@ | |||
| import * as cloudwatch from '@aws-cdk/aws-cloudwatch'; | |||
Contributor
There was a problem hiding this comment.
This logic should be moved into ssm.ts.
Comment on lines
+8
to
+9
| constructor(private readonly responsePlanArn: string) { | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| constructor(private readonly responsePlanArn: string) { | |
| } | |
| constructor(private readonly responsePlanArn: string) { } |
Contributor
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
callumthomson
added a commit
to callumthomson/aws-cdk
that referenced
this pull request
Jul 15, 2022
Author
|
Sorry, I have been on a month long vacation and could not check-in earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR will add SSM Incident action to cloudwatch alarm.
The arn format was taken from the UI console (under Incident Manager Response Plan)
closes #20552
Used #16923 as a reference