docs(secretsmanager): replace IAM example with RDS example#20404
Conversation
|
|
rix0rrr
approved these changes
May 19, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kaizencc
requested changes
Jun 3, 2022
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
@jerry-aws looks like you need to add import * as rds from '@aws-cdk/aws-rds' to the rosetta/default.ts-fixture file inside the secretsmanager folder. Currently the examples you've provided are failing the build
Contributor
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
Repeat of #20404 which fell off my radar. An internal review found the use of a Secrets Manager secret to create an IAM user to be an anti-pattern. Changed this example to create an RDS instance instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An internal review found the use of a Secrets Manager secret to create an IAM user to be an anti-pattern. Changed this example to create an RDS instance instead.