chore: stop mypy from complaining about the Metric class#20369
Merged
mergify[bot] merged 2 commits intoaws:masterfrom May 19, 2022
Merged
chore: stop mypy from complaining about the Metric class#20369mergify[bot] merged 2 commits intoaws:masterfrom
Metric class#20369mergify[bot] merged 2 commits intoaws:masterfrom
Conversation
|
|
kornicameister
commented
May 17, 2022
| this.unit = props.unit; | ||
| this.account = props.account; | ||
| this.region = props.region; | ||
| this.warnings = undefined; |
Contributor
Author
There was a problem hiding this comment.
Honestly, not really sure if that's how this is supposed to be done.
Metric class
rix0rrr
approved these changes
May 19, 2022
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
This is actually a jsii problem, but I'll approve it to get rid of the warnings.
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this pull request
May 23, 2022
Fixes: aws#20219 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20219
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license