Skip to content

feat(s3): add noncurrentVersionsToRetain property to lifecycle rule#20348

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
mayforblue:s3-add-lifecycle-rule-param
May 19, 2022
Merged

feat(s3): add noncurrentVersionsToRetain property to lifecycle rule#20348
mergify[bot] merged 7 commits intoaws:masterfrom
mayforblue:s3-add-lifecycle-rule-param

Conversation

@mayforblue
Copy link
Copy Markdown
Contributor

@mayforblue mayforblue commented May 14, 2022

Fixes #19784


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 14, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 14, 2022 15:06
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels May 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ae63bc9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 85604d9 into aws:master May 19, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mayforblue mayforblue deleted the s3-add-lifecycle-rule-param branch May 19, 2022 13:17
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
…aws#20348)

Fixes aws#19784

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(S3): Cannot specify number of noncurrent versions to retain in LifeCycle rule without transitioning the StorageClass

3 participants