Skip to content

chore: undo automatic assigning to PRs#20312

Merged
mergify[bot] merged 2 commits intomasterfrom
huijbers/remove-round-robin-assignment
May 12, 2022
Merged

chore: undo automatic assigning to PRs#20312
mergify[bot] merged 2 commits intomasterfrom
huijbers/remove-round-robin-assignment

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented May 12, 2022

After running with this for a while, we feel it's stress-inducing
and not helping.

Thanks for the effort of putting this together Peter, and sorry that
I asked you to. I regret not thinking this through more, but I
appreciate the effort you put in.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

After running with this for a while, we feel it's stress-inducing
and not helping.

Thanks for the effort of putting this together Peter, and sorry that
I asked you to. I regret not thinking this through more, but I
appreciate the effort you put in.
@rix0rrr rix0rrr requested a review from a team May 12, 2022 13:50
@rix0rrr rix0rrr self-assigned this May 12, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 12, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2022 13:51
@github-actions github-actions bot added the p2 label May 12, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 12, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 41e2bfc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 783e7bb into master May 12, 2022
@mergify mergify bot deleted the huijbers/remove-round-robin-assignment branch May 12, 2022 16:41
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@peterwoodworth
Copy link
Copy Markdown
Contributor

Sounds good!

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
After running with this for a while, we feel it's stress-inducing
and not helping.

Thanks for the effort of putting this together Peter, and sorry that
I asked you to. I regret not thinking this through more, but I
appreciate the effort you put in.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants