Skip to content

fix(rds): tokens should not be lowercased#20287

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
Zharktas:master
May 11, 2022
Merged

fix(rds): tokens should not be lowercased#20287
mergify[bot] merged 3 commits intoaws:masterfrom
Zharktas:master

Conversation

@Zharktas
Copy link
Copy Markdown
Contributor

Fixes #18802

Pretty much does the suggested fix in the issue.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 11, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels May 11, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 11, 2022 10:32
@Zharktas Zharktas force-pushed the master branch 2 times, most recently from 0bd43c5 to 5f7d8ec Compare May 11, 2022 11:35
rix0rrr
rix0rrr previously approved these changes May 11, 2022
@rix0rrr rix0rrr changed the title fix(aws-rds): tokens should not be lowercased fix(rds): tokens should not be lowercased May 11, 2022
@mergify mergify bot dismissed rix0rrr’s stale review May 11, 2022 11:57

Pull request has been modified.

kaizencc
kaizencc previously approved these changes May 11, 2022
@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 11, 2022
@mergify mergify bot dismissed kaizencc’s stale review May 11, 2022 14:17

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 144d2e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5429e55 into aws:master May 11, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
Fixes aws#18802

Pretty much does the suggested fix in the issue.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

5 participants