Skip to content

chore(merge-back): 1.153.1#20053

Merged
mergify[bot] merged 4 commits intomasterfrom
merge-back/1.153.1
Apr 23, 2022
Merged

chore(merge-back): 1.153.1#20053
mergify[bot] merged 4 commits intomasterfrom
merge-back/1.153.1

Conversation

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 23, 2022

See CHANGELOG

rix0rrr and others added 3 commits April 22, 2022 22:18
Certain fields of the `ImageBuilder` service used to be typed as
`Json` (i.e., arbitrary data).

- In TypeScript, you would pass that data as an object literal with
  *capitalized* properties.
- In Python, you would pass it as a `dict`
- In Java, you would pass it as a `HashMap`
- etc

In the new CloudFormation spec, it is now typed as a struct. This
adds type information that didn't use to be there. CDK now generates
classes for it.

- In TypeScript, you must now pass an object literal with
  *lowercased* properties.
- In Python, you must now pass it as an instance of a class.
- In Java, you must now use a builder to construct the object.

Because of this, adding types to properties is a breaking change to the
L1 layer. If you don't pass the information correctly, an empty object
comes out the other end, probably not rendering what you expected.

This is disastrous for construct libraries that are using L1s, as they
are not in control when users upgrade their libraries but they may all
of a sudden be broken with no recourse. Case in point:
[ParallelCluster3](https://github.com/aws/aws-parallelcluster)
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Apr 23, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 23, 2022

@github-actions github-actions bot added the p2 label Apr 23, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 23, 2022 04:29
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 23, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9a7e599
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dacc9ab into master Apr 23, 2022
@mergify mergify bot deleted the merge-back/1.153.1 branch April 23, 2022 05:16
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 23, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve p2 pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants