Skip to content

chore(release): v1.153.1#20046

Merged
mergify[bot] merged 2 commits intoreleasefrom
patch/v1.153.1
Apr 22, 2022
Merged

chore(release): v1.153.1#20046
mergify[bot] merged 2 commits intoreleasefrom
patch/v1.153.1

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Apr 22, 2022


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Certain fields of the `ImageBuilder` service used to be typed as
`Json` (i.e., arbitrary data).

- In TypeScript, you would pass that data as an object literal with
  *capitalized* properties.
- In Python, you would pass it as a `dict`
- In Java, you would pass it as a `HashMap`
- etc

In the new CloudFormation spec, it is now typed as a struct. This
adds type information that didn't use to be there. CDK now generates
classes for it.

- In TypeScript, you must now pass an object literal with
  *lowercased* properties.
- In Python, you must now pass it as an instance of a class.
- In Java, you must now use a builder to construct the object.

Because of this, adding types to properties is a breaking change to the
L1 layer. If you don't pass the information correctly, an empty object
comes out the other end, probably not rendering what you expected.

This is disastrous for construct libraries that are using L1s, as they
are not in control when users upgrade their libraries but they may all
of a sudden be broken with no recourse. Case in point:
[ParallelCluster3](https://github.com/aws/aws-parallelcluster)
@rix0rrr rix0rrr added the pr/no-squash This PR should be merged instead of squash-merging it label Apr 22, 2022
@rix0rrr rix0rrr requested a review from a team April 22, 2022 20:21
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 22, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 22, 2022 20:21
@github-actions github-actions bot added the p2 label Apr 22, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 22, 2022
CHANGELOG.md Outdated

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.153.1](https://github.com/aws/aws-cdk/compare/v1.153.0...v1.153.1) (2022-04-22)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build error is coming from this line having the wrong number of #'s, I'm removing one to see if that fixes it.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a266179
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 22, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9a7e599 into release Apr 22, 2022
@mergify mergify bot deleted the patch/v1.153.1 branch April 22, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants