feat(stepfunctions): add fromStateMachineName to import a state machine by resource name#20036
feat(stepfunctions): add fromStateMachineName to import a state machine by resource name#20036mergify[bot] merged 14 commits intoaws:mainfrom
fromStateMachineName to import a state machine by resource name#20036Conversation
|
|
fromStateMachineName to import a state machine by resource name
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thank you for your contribution! The addition of an API requires the addition of documentation in the README. Please see the Pull Request section of our Contributing Guide for more information.
Pull request has been modified.
|
@TheRealAmazonKendra thx for your feedback! I've added an usage example in the README. What do you think about it? |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thanks for the update on this. Just one quick change requested below. Also, I think we'll need an integration test for this change. The PR linter caught it after I missed requesting it last review.
Pull request has been modified.
|
I'm unclear on why the build is failing but we also cannot approve/merge PRs with a failing build. |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR got rough because of our branch change. I'm going to go ahead and help resolve some of these conflicts since they have nothing to do with your change. I'll be pushing those updates today. |
3fff3c8 to
98ee140
Compare
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
I think that I got this back to your intended changes rather than all the extras due to changing the branch. My apologies if anything got lost from your changes, this was a bit messy to untangle. I do see why it's failing now, though.
Stack.of(this) needs to take in a construct and in this context this is a resource. Stack.of(scope) should work, though.
|
This PR has been in the CHANGES REQUESTED & BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Pull request has been modified.
|
hi @TheRealAmazonKendra , sry for the late reply! I want to get this done now 🙂 |
|
Hi @TheRealAmazonKendra is there anything else you want me to do? 😊 |
|
@JulianKahnert See my note about the incorrect name of the test. That should be all, I think. |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thanks for all your work on this!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…hine by resource name (aws#20036) ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license