Skip to content

chore(cfnspec): Add coverage directory to npmignore#20016

Merged
mergify[bot] merged 4 commits intoaws:v1-mainfrom
msrose:patch-1
Jun 30, 2022
Merged

chore(cfnspec): Add coverage directory to npmignore#20016
mergify[bot] merged 4 commits intoaws:v1-mainfrom
msrose:patch-1

Conversation

@msrose
Copy link
Copy Markdown

@msrose msrose commented Apr 21, 2022

Installing cfnspec shows the coverage directory is being published to npm. I assume this should be excluded since build artifacts aren't typically published, and at a glance most CDK packages exclude any build artifacts from the published package. (If there is a specific reason why the coverage folder is being published, please advise since I'd be interested to understand the use case.)

$ npm install @aws-cdk/cfnspec
$ ls -1 node_modules/@aws-cdk/cfnspec/
CHANGELOG.md
LICENSE
coverage
lib
package.json
...
$  ls -1 node_modules/@aws-cdk/cfnspec/coverage
base.css
block-navigation.js
build-tools
favicon.png
index.html
junit.xml
...

All Submissions:

Adding new Unconventional Dependencies:

  • N/A

New Features

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 21, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 21, 2022 15:02
@github-actions github-actions bot added the p2 label Apr 21, 2022
@rix0rrr
Copy link
Copy Markdown
Contributor

rix0rrr commented Jun 30, 2022

@Mergifyio backport main

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2022

backport main

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 28431dc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f15b18a into aws:v1-main Jun 30, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Jun 30, 2022
Installing cfnspec shows the coverage directory is being published to npm. I assume this should be excluded since build artifacts aren't typically published, and at a glance most CDK packages exclude any build artifacts from the published package. (If there is a specific reason why the coverage folder is being published, please advise since I'd be interested to understand the use case.)

```
$ npm install @aws-cdk/cfnspec
$ ls -1 node_modules/@aws-cdk/cfnspec/
CHANGELOG.md
LICENSE
coverage
lib
package.json
...
$  ls -1 node_modules/@aws-cdk/cfnspec/coverage
base.css
block-navigation.js
build-tools
favicon.png
index.html
junit.xml
...
```
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* N/A

### New Features

* N/A

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit f15b18a)
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 30, 2022

backport main

✅ Backports have been created

Details

mergify bot added a commit that referenced this pull request Jun 30, 2022
…#20931)

This is an automatic backport of pull request #20016 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
@msrose msrose deleted the patch-1 branch June 30, 2022 15:00
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
…) (aws#20931)

This is an automatic backport of pull request aws#20016 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
@HBobertz HBobertz mentioned this pull request Nov 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants