chore: remove extra console.log#19973
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Apr 19, 2022
corymhall:corymhall/fix-find-latest-release
Merged
chore: remove extra console.log#19973mergify[bot] merged 2 commits intoaws:masterfrom corymhall:corymhall/fix-find-latest-release
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/fix-find-latest-release
Conversation
`find-latest-release.js` is used in `scripts/check-api-compatibility.sh`. `check-api-compatibility` reads the version from the `console.log` in `find-latest-release.js`. When there are API rate limit errors we are logging a message about sleeping which is what `check-api-compatibility` is seeing as the version. For example, this is a log message from a PR build ``` Listing jsii packages... lerna notice cli v4.0.0 lerna info ci enabled lerna success found 252 packages Filtering on existing packages on NPM... Determining baseline version... Build version: 1.152.0. Released version: Sleeping for 58 seconds 1.152.0. Using version 'Sleeping for 58 seconds 1.152.0' as the baseline... for: -c: line 0: unexpected EOF while looking for matching `"' for: -c: line 1: syntax error: unexpected end of file for: -c: line 0: unexpected EOF while looking for matching `"' for: -c: line 1: syntax error: unexpected end of file ```
comcalvi
approved these changes
Apr 19, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
`find-latest-release.js` is used in `scripts/check-api-compatibility.sh`. `check-api-compatibility` reads the version from the `console.log` in `find-latest-release.js`. When there are API rate limit errors we are logging a message about sleeping which is what `check-api-compatibility` is seeing as the version. For example, this is a log message from a PR build ``` Listing jsii packages... lerna notice cli v4.0.0 lerna info ci enabled lerna success found 252 packages Filtering on existing packages on NPM... Determining baseline version... Build version: 1.152.0. Released version: Sleeping for 58 seconds 1.152.0. Using version 'Sleeping for 58 seconds 1.152.0' as the baseline... for: -c: line 0: unexpected EOF while looking for matching `"' for: -c: line 1: syntax error: unexpected end of file for: -c: line 0: unexpected EOF while looking for matching `"' for: -c: line 1: syntax error: unexpected end of file ``` ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find-latest-release.jsis used inscripts/check-api-compatibility.sh.check-api-compatibilityreadsthe version from the
console.loginfind-latest-release.js.When there are API rate limit errors we are logging a message about
sleeping which is what
check-api-compatibilityis seeing as theversion. For example, this is a log message from a PR build
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license