Skip to content

chore: remove extra console.log#19973

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/fix-find-latest-release
Apr 19, 2022
Merged

chore: remove extra console.log#19973
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/fix-find-latest-release

Conversation

@corymhall
Copy link
Copy Markdown
Contributor

find-latest-release.js is used in
scripts/check-api-compatibility.sh. check-api-compatibility reads
the version from the console.log in find-latest-release.js.

When there are API rate limit errors we are logging a message about
sleeping which is what check-api-compatibility is seeing as the
version. For example, this is a log message from a PR build

Listing jsii packages...
lerna notice cli v4.0.0
lerna info ci enabled
lerna success found 252 packages
Filtering on existing packages on NPM...
Determining baseline version...
Build version:    1.152.0.
Released version: Sleeping for 58 seconds
1.152.0.
Using version 'Sleeping for 58 seconds
1.152.0' as the baseline...
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`find-latest-release.js` is used in
`scripts/check-api-compatibility.sh`. `check-api-compatibility` reads
the version from the `console.log` in `find-latest-release.js`.

When there are API rate limit errors we are logging a message about
sleeping which is what `check-api-compatibility` is seeing as the
version. For example, this is a log message from a PR build

```
Listing jsii packages...
lerna notice cli v4.0.0
lerna info ci enabled
lerna success found 252 packages
Filtering on existing packages on NPM...
Determining baseline version...
Build version:    1.152.0.
Released version: Sleeping for 58 seconds
1.152.0.
Using version 'Sleeping for 58 seconds
1.152.0' as the baseline...
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file
```
@corymhall corymhall requested a review from rix0rrr April 19, 2022 18:07
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 19, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 19, 2022
@github-actions github-actions bot added the p2 label Apr 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 19, 2022 18:09
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d128155
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7606b71 into aws:master Apr 19, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
`find-latest-release.js` is used in
`scripts/check-api-compatibility.sh`. `check-api-compatibility` reads
the version from the `console.log` in `find-latest-release.js`.

When there are API rate limit errors we are logging a message about
sleeping which is what `check-api-compatibility` is seeing as the
version. For example, this is a log message from a PR build

```
Listing jsii packages...
lerna notice cli v4.0.0
lerna info ci enabled
lerna success found 252 packages
Filtering on existing packages on NPM...
Determining baseline version...
Build version:    1.152.0.
Released version: Sleeping for 58 seconds
1.152.0.
Using version 'Sleeping for 58 seconds
1.152.0' as the baseline...
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file
for: -c: line 0: unexpected EOF while looking for matching `"'
for: -c: line 1: syntax error: unexpected end of file
```


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants