fix(integ-runner): enable all feature flags by default#19955
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Apr 18, 2022
corymhall:corymhall/fix-snapshots
Merged
fix(integ-runner): enable all feature flags by default#19955mergify[bot] merged 3 commits intoaws:masterfrom corymhall:corymhall/fix-snapshots
mergify[bot] merged 3 commits intoaws:masterfrom
corymhall:corymhall/fix-snapshots
Conversation
This was overlooked when generating the snapshots on v1 and was in place in the old `cdk-integ-tools` package. This will prevent snapshot differences on v2.
|
|
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
This was overlooked when generating the snapshots on v1 and was in place in the old `cdk-integ-tools` package. This will prevent snapshot differences on v2. The code changes are in `integ-runner/lib/runner/runners.ts` and consist of making sure that the features flags are enabled when running any CDK command. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was overlooked when generating the snapshots on v1 and was in place
in the old
cdk-integ-toolspackage. This will prevent snapshotdifferences on v2.
The code changes are in
integ-runner/lib/runner/runners.tsand consist of making sure that the features flags are enabled when running any CDK command.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license