fix(ecr): scanOnPush not supported in certain regions#19940
fix(ecr): scanOnPush not supported in certain regions#19940mergify[bot] merged 7 commits intomasterfrom
Conversation
|
|
| repositoryPolicyText: Lazy.any({ produce: () => this.policyDocument }), | ||
| lifecyclePolicy: Lazy.any({ produce: () => this.renderLifecyclePolicy() }), | ||
| imageScanningConfiguration: props.imageScanOnPush ? { scanOnPush: true } : { scanOnPush: false }, | ||
| imageScanningConfiguration: props.imageScanOnPush ? { scanOnPush: props.imageScanOnPush } : undefined, |
There was a problem hiding this comment.
My earlier suggestion was wrong (and syntactically incorrect doh!).
It should be:
imageScanningConfiguration: props.imageScanOnPush === undefined ? undefined : { scanOnPush: props.imageScanOnPush }This way only when imageScanOnPush is undefined will imageScanningConfiguration be omitted, but explicitly setting it to false or true will still result in generating an imageScanningConfiguration.
There was a problem hiding this comment.
You're right, I'll fix that up and add a test to verify functionality
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
fixes aws#19918 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes #19918
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license