feat(cli): make ecr images immutable when created from cdk bootstrap#19937
Merged
mergify[bot] merged 3 commits intoaws:masterfrom May 17, 2022
Merged
feat(cli): make ecr images immutable when created from cdk bootstrap#19937mergify[bot] merged 3 commits intoaws:masterfrom
mergify[bot] merged 3 commits intoaws:masterfrom
Conversation
|
|
Contributor
|
@gitpod-io[bot] is not allowed to run commands |
Contributor
Author
|
@rix0rrr I think this is what was described in the issue? |
ffe9689 to
5e9c923
Compare
TheRealAmazonKendra
previously requested changes
Apr 26, 2022
Contributor
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thanks for the contribution! We just need a test for this change.
5e9c923 to
069ccca
Compare
Pull request has been modified.
Contributor
Author
Added new test to verify the |
ea763a9 to
753b550
Compare
c460354 to
ebdf324
Compare
As CDK creates images always with different name/tag, it can be ensured that those are not changed at the repository side
Contributor
Author
|
@TheRealAmazonKendra Is there something that needs to be changed in PR? |
TheRealAmazonKendra
approved these changes
May 17, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this pull request
May 23, 2022
…ws#19937) As CDK creates images always with different name/tag, it can be ensured that those are not changed at the repository side. Changes default functionality without offering immutability setting [`AWS::ECR::Repository.ImageTagMutability`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-imagetagmutability) Fixes aws#18376 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As CDK creates images always with different name/tag, it can be ensured that those are not changed at the repository side.
Changes default functionality without offering immutability setting
AWS::ECR::Repository.ImageTagMutabilityFixes #18376
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license