chore: assign aws-cdk-owners members to PRs#19925
Conversation
|
|
|
Action ran successfully, so the token works here https://github.com/aws/aws-cdk/runs/6032421375?check_suite_focus=true Repository here, feel free to give feedback on code written. Will make this an official aws owned repo if we like how this automation works. Also, should we disable the automatic requesting of reviews from |
kaizencc
left a comment
There was a problem hiding this comment.
Thanks! I read the source code and I'll do my best to relay comments from that.
- I think it's a bit cumbersome to have to configure both
pull_request_target: types: [opened]andtarget: "pull-requests"on the action itself. If you omit one or the other, suddenly things don't work the way you think they do. It's more robust to exit the action gracefully if it encounters an issue whentarget: "pull_request", instead of relying on the workflow configuration to only send the action PRs. - should
core-teambe renamed something that conveys what it's doing, likeexempt-teamorexempt-members? We want the core team to be exempt from assignment (at least I do) but that's our own implementation detail.
|
Changed it to As for the first point, I could make it so that if the issue opened is an issue then it only counts issues, and same with PRs. I think I like that better |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When a PR is opened, this automation will: - Assign the member from `aws-cdk-owners` with the lowest number of currently assigned PRs to the PR - Do nothing if the issue was submitted by someone from `aws-cdk-team` ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When a PR is opened, this automation will:
aws-cdk-ownerswith the lowest number of currently assigned PRs to the PRaws-cdk-teamAll Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license