feat(cli): allow diffing against a processed template#19908
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Jul 14, 2022
Merged
feat(cli): allow diffing against a processed template#19908mergify[bot] merged 3 commits intoaws:mainfrom
mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
In some cases, using an unprocessed template with `CfnInclude` fails, most commonly because the unprocessed template can contain cycles between the resources. When this happens, customers need to include the processed template instead, but when that happens, the `diff` command returns the wrong results, because it compares against the original, and thus unprocessed, template. Add a new command-line switch to the `diff` command that allows comparing against the processed template, which gives the correct results in this case.
|
|
Contributor
Author
|
@rix0rrr would appreciate a look here 🙂. |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
guessi
pushed a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
In some cases, using an unprocessed template with `CfnInclude` fails, most commonly because the unprocessed template can contain cycles between the resources. When this happens, customers need to include the processed template instead, but when that happens, the `diff` command returns the wrong results, because it compares against the original, and thus unprocessed, template. Add a new command-line switch to the `diff` command that allows comparing against the processed template, which gives the correct results in this case. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, using an unprocessed template with
CfnIncludefails,most commonly because the unprocessed template can contain cycles between the resources.
When this happens, customers need to include the processed template instead,
but when that happens, the
diffcommand returns the wrong results,because it compares against the original, and thus unprocessed, template.
Add a new command-line switch to the
diffcommand that allows comparing against the processed template,which gives the correct results in this case.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license