Two comments/questions:

1. I see now that the CFN resource is named AWS::Lambda::Url not AWS::Lambda::FunctionUrl, how about dropping the function prefix everywhere in the code (and filename). I think this is more inline with the code base.
2. more important: I see that updating the TargetFunctionArn and/or Qualifier can be done (CFN) without interruption (= no replacement). This is very useful because it means you can keep the same url when changing the function or qualifier behind it. With the current implementation, the URL is created in the scope of the function/qualifier, so if the function/qualifier changes the URL will always be recreated. I think we need to revert the relation here = have a mapTo() function in the URL resource:

const myApiUrl = new Url(this, 'MyApiUrl', { authType: FunctionUrlAuthType.NONE });
myApiUrl.mapTo(myFn);

(making some tests now with CFN to confirm this)

@rix0rrr wdyt?

2. more important: I see that updating the TargetFunctionArn and/or Qualifier can be done (CFN) without interruption (= no replacement). This is very useful because it means you can keep the same url when changing the function or qualifier behind it. With the current implementation, the URL is created in the scope of the function/qualifier, so if the function/qualifier changes the URL will always be recreated. I think we need to revert the relation here = have a mapTo() function in the URL resource:

Unfortunately the doc is incorrect here...

VS

😢

@jogold Regarding the FunctionUrl nomenclature, the Lambda documentation and console refer to them as Function URLs instead of just URLs. Also, there might be cases where just URL might be confused with URL from the default node engine modules.

@rix0rrr @kaizen3031593 Can we please try to merge this change?

const myApiUrl = new Url(this, 'MyApiUrl', { authType: FunctionUrlAuthType.NONE });
myApiUrl.mapTo(myFn);

Isn't this effectively the same as:

new Url(this, 'MyApiUrl', { 
  authType: ...,
  function: myFn,
});

? Which you can already do?

const myApiUrl = new Url(this, 'MyApiUrl', { authType: FunctionUrlAuthType.NONE });
myApiUrl.mapTo(myFn);

Isn't this effectively the same as:

new Url(this, 'MyApiUrl', { 
  authType: ...,
  function: myFn,
});

? Which you can already do?

Yes

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: bd6704c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).