Skip to content

chore: fix typo in warning#19810

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
rcollette:master
Apr 8, 2022
Merged

chore: fix typo in warning#19810
mergify[bot] merged 3 commits intoaws:masterfrom
rcollette:master

Conversation

@rcollette
Copy link
Copy Markdown
Contributor

Warning message grammar correction


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Grammar correction
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 8, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2022 00:23
@github-actions github-actions bot added the p2 label Apr 8, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@rix0rrr rix0rrr changed the title Update security-group.ts chore: fix typo in warning Apr 8, 2022
rix0rrr
rix0rrr previously approved these changes Apr 8, 2022
@mergify mergify bot dismissed rix0rrr’s stale review April 8, 2022 08:58

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1192830 into aws:master Apr 8, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 71b8146
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

otaviomacedo pushed a commit that referenced this pull request Apr 11, 2022
Warning message grammar correction


----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
Warning message grammar correction


----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants