feat(aws-cognito): send emails with a verified domain#19790
feat(aws-cognito): send emails with a verified domain#19790mergify[bot] merged 11 commits intoaws:masterfrom
Conversation
|
|
comcalvi
left a comment
There was a problem hiding this comment.
Looks great! A few minor comments.
@hassanazharkhan this would be considered a new feature. Can you add a new integration test for this? |
|
@corymhall I was considering this as fix as with current implementation, I'm not able to use SES domain identity, since you're considering this a feat, then It'd definitely require inter.test and README changes. let me add it, thanks so much! |
|
Hello, @hassanazharkhan. |
|
@kt-hr Tye only thing I need to add is the integ.test and after that this one will be good to merge, I'll try to do that today. At the same time I'm happy to close this one if you'd like contribute? |
comcalvi
left a comment
There was a problem hiding this comment.
Looks pretty good overall. This is just a preliminary pass until the code build passes
|
@comcalvi Would appreciate another pass |
comcalvi
left a comment
There was a problem hiding this comment.
Looks really good! A few small comments.
comcalvi
left a comment
There was a problem hiding this comment.
Please update the PR description to describe these changes.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@comcalvi Can you please re-approve, not sure why the build failed so I just rebase my branch from master it is passed now! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
When sending emails with a verified domain, the email address does not need to be verified. In that case, the identity of the SourceArn in EmailConfiguration is allowed to be set to the domain instead of the email address. closes [aws#19762](aws#19762) ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When sending emails with a verified domain, the email address does not need to be verified.
In that case, the identity of the SourceArn in EmailConfiguration is allowed to be set to the domain instead of the email address.
closes #19762
All Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integto deploy the infrastructure and generate the snapshot (i.e.cdk-integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license