Skip to content

chore: add issue reprioritization action#19758

Merged
mergify[bot] merged 4 commits intomasterfrom
conroy/issue-graduation-manager
Apr 7, 2022
Merged

chore: add issue reprioritization action#19758
mergify[bot] merged 4 commits intomasterfrom
conroy/issue-graduation-manager

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Apr 4, 2022

Add an issue graduation action with the following configuration:

  • run once a week on Sunday
  • finds p2 issues and graduates them to p1 if there are 20+ reactions
  • on every graduated issue, provides an automated message: "This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue."

See the action here.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from rix0rrr April 4, 2022 23:07
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 4, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 4, 2022
@github-actions github-actions bot added the p2 label Apr 4, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 4, 2022 23:07
@rix0rrr rix0rrr changed the title chore: add issue graduation action chore: add issue releveling action Apr 5, 2022
@rix0rrr rix0rrr changed the title chore: add issue releveling action chore: add issue repriotization action Apr 5, 2022
@rix0rrr rix0rrr changed the title chore: add issue repriotization action chore: add issue reprioritization action Apr 5, 2022
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find a different term for "graduation" here. That word has been overloaded with other activities we perform, and is confusing me.

skips graduation on any issue labeled no-graduation.

The 0-touch solution would be: don't do reprioritization if we've already reprioritized it once before. The only reason why it would be at a lower level then is because someone manually downprioritized it again (in which case that's a strong enough signal that The Machine should shut up and not do it again).

@kaizencc
Copy link
Copy Markdown
Contributor Author

kaizencc commented Apr 6, 2022

3 updates since the last review:

  • linked PRs will also be reprioritized
  • renamed everything "graduation" into "reprioritization"
  • no-touch solution to filtering for already reprioritized issues.

the no-touch solution is not in this PR but in the action itself. Adds a "unique" metadata to the message like <!--p2 to p1-->. The idea here is to differentiate different runs of the same action (i.e. guard against an issue moved from p2 to p1, and then separately from p1 to p0.). We don't want to stop the p1 to p0 move from happening just because it also moved from p2 to p1. We are not doing that here but that is a valid use case that my action should support.

@kaizencc kaizencc requested a review from rix0rrr April 6, 2022 21:01
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9d4319c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3665db9 into master Apr 7, 2022
@mergify mergify bot deleted the conroy/issue-graduation-manager branch April 7, 2022 08:00
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
Add an issue graduation action with the following configuration:

- run once a week on Sunday
- finds `p2` issues and graduates them to `p1` if there are 20+ reactions
- on every graduated issue, provides an automated message: "This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue."

See the action [here](https://github.com/kaizen3031593/issue-graduation-manager).

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants