fix(aws-cloudfront): Add sslSupportMethod#19737
Conversation
- Modified to allow selection of sslSupportMethod closes aws#19476
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
comcalvi
left a comment
There was a problem hiding this comment.
Looks great! Just a few small comments. Could we also add a test to this? At least check that we correctly fall back to SNI if the user doesn't specify an SSLMethod, and that if the user does specify an SSLMethod, we use the one they specified.
| * which hostname it is attempting to connect to at the start of the handshaking process. This allows a server to present | ||
| * multiple certificates on the same IP address and TCP port number and hence allows multiple secure (HTTPS) websites |
There was a problem hiding this comment.
can we remove the extra space at the front of these two lines?
There was a problem hiding this comment.
Corrected comment.
| * | ||
| * See the CloudFront SSL for more details about pricing : https://aws.amazon.com/cloudfront/custom-ssl-domains/ | ||
| * | ||
| * @default - SSLMethod.SNI |
There was a problem hiding this comment.
should be
@default SSLMethod.SNI
There was a problem hiding this comment.
Corrected comment.
- Add test for sslSupportMethod - Corrected comment closes aws#19476
|
@comcalvi : Hi, I modified the comment and added a test. Please check. 🙇 |
comcalvi
left a comment
There was a problem hiding this comment.
Thanks for the contribution
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
- Modified to allow selection of sslSupportMethod closes #19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Modified to allow selection of sslSupportMethod closes aws#19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
closes #19476
All Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integto deploy the infrastructure and generate the snapshot (i.e.cdk-integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license