Skip to content

fix(apigateway): allow using GENERATE_IF_NEEDED for the physical name in LambdaRestApi#19638

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:fix/rest-api-physical-name
Mar 31, 2022
Merged

fix(apigateway): allow using GENERATE_IF_NEEDED for the physical name in LambdaRestApi#19638
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:fix/rest-api-physical-name

Conversation

@skinny85
Copy link
Copy Markdown
Contributor

Fixes #9374


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 31, 2022

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6186b58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e817381 into aws:master Mar 31, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the fix/rest-api-physical-name branch April 1, 2022 22:35
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
… in LambdaRestApi (aws#19638)

Fixes aws#9374

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p2

Projects

None yet

4 participants