Skip to content

chore: apply v2 trove classifier on v2 python packages#19630

Merged
mergify[bot] merged 2 commits intomasterfrom
rmuller/pypi-trove-classifier-v2
Mar 30, 2022
Merged

chore: apply v2 trove classifier on v2 python packages#19630
mergify[bot] merged 2 commits intomasterfrom
rmuller/pypi-trove-classifier-v2

Conversation

@RomainMuller
Copy link
Copy Markdown
Contributor

Those are currently incorrectly listed against version 1 of the
Framework :: AWS CDK trove classifier. This changes so the v2 branch
correctly uses version 2 here.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller RomainMuller self-assigned this Mar 30, 2022
@RomainMuller RomainMuller requested a review from a team March 30, 2022 17:50
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 30, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 30, 2022
@github-actions github-actions bot added the p2 label Mar 30, 2022
@RomainMuller
Copy link
Copy Markdown
Contributor Author

The trove classifier registration was requested in pypa/trove-classifiers#98. We do not need to wait for this to be accepted before this can be merged (PyPI will not reject unregistered trove classifiers unless they start with Private ::).

Those are currently incorrectly listed against version 1 of the
Framework :: AWS CDK trove classifier. This changes so the v2 branch
correctly uses version 2 here.
@RomainMuller RomainMuller force-pushed the rmuller/pypi-trove-classifier-v2 branch from 06e845d to 2cf4baf Compare March 30, 2022 18:02
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6fdbd81
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f1c465d into master Mar 30, 2022
@mergify mergify bot deleted the rmuller/pypi-trove-classifier-v2 branch March 30, 2022 20:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

madeline-k added a commit that referenced this pull request Apr 1, 2022
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
Those are currently incorrectly listed against version 1 of the
Framework :: AWS CDK trove classifier. This changes so the v2 branch
correctly uses version 2 here.


----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants