chore: fix tests that use node.metadataentry#19545
Merged
mergify[bot] merged 8 commits intomasterfrom Mar 25, 2022
Merged
Conversation
|
|
TheRealAmazonKendra
approved these changes
Mar 25, 2022
Contributor
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for also removing all the extra spaces in the tests.
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
Does this for everything except the tests in core that are specifically testing `Aspects`. There's less of a chance that those tests are disturbed by adding annotations elsewhere in the CDK. Closes aws#19544 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this for everything except the tests in core that are specifically testing
Aspects. There's less of a chance that those tests are disturbed by adding annotations elsewhere in the CDK.Closes #19544
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license