Skip to content

chore(s3): migrate tests to use assertions' annotations class#19466

Merged
mergify[bot] merged 3 commits intomasterfrom
conroy/s3fix
Mar 18, 2022
Merged

chore(s3): migrate tests to use assertions' annotations class#19466
mergify[bot] merged 3 commits intomasterfrom
conroy/s3fix

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

Also removes an unnecessary dependency on having no messages on a stack, since additional messages can be introduced in the future. Related #19465.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team March 18, 2022 17:59
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 18, 2022

@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Mar 18, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cdf97fa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5cd1540 into master Mar 18, 2022
@mergify mergify bot deleted the conroy/s3fix branch March 18, 2022 23:40
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

iliapolo pushed a commit that referenced this pull request Mar 20, 2022
Also removes an unnecessary dependency on having no messages on a stack, since additional messages can be introduced in the future. Related #19465.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-s3 Related to Amazon S3 contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants