chore(v2): only advertise alpha packages with L2s#19440
Merged
mergify[bot] merged 3 commits intomasterfrom Mar 18, 2022
Merged
Conversation
Right now, we advertise `alpha` packages for every service module that is marked as `experimental`. However, all L1-only packages are all always marked as `experimental` as a protection against human mistakes: so that when we add in L2s we don't accidentally mark them as `stable` right away. This leads to every CFN-only package having an advertising clause for an `alpha` package that doesn't even exist. Do a source code check to only advertise if it looks like there are actual L2s.
RomainMuller
approved these changes
Mar 17, 2022
|
|
madeline-k
approved these changes
Mar 17, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
pushed a commit
that referenced
this pull request
Mar 20, 2022
Right now, we advertise `alpha` packages for every service module that is marked as `experimental`. However, all L1-only packages are all always marked as `experimental` as a protection against human mistakes: so that when we add in L2s we don't accidentally mark them as `stable` right away. This leads to every CFN-only package having an advertising clause for an `alpha` package that doesn't even exist. Do a source code check to only advertise if it looks like there are actual L2s. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we advertise
alphapackages for every service module thatis marked as
experimental.However, all L1-only packages are all always marked as
experimentalasa protection against human mistakes: so that when we add in L2s we don't
accidentally mark them as
stableright away.This leads to every CFN-only package having an advertising clause for
an
alphapackage that doesn't even exist.Do a source code check to only advertise if it looks like there are
actual L2s.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license