feat(aws-ec2): Enable/disable EC2 "Detailed Monitoring"#19437
feat(aws-ec2): Enable/disable EC2 "Detailed Monitoring"#19437mergify[bot] merged 12 commits intoaws:masterfrom Dzhuneyt:dzhuneyt/issue-19346-ec2-detailed-monitoring
Conversation
|
|
corymhall
left a comment
There was a problem hiding this comment.
Just one minor comment on the docstring, otherwise this looks good!
| readonly requireImdsv2?: boolean; | ||
|
|
||
| /** | ||
| * Whether "Detailed Monitoring" is enabled for this instance |
There was a problem hiding this comment.
Can you add a comment here as well about the extra cost (same thing you have in the readme)
There was a problem hiding this comment.
@corymhall added a note about the extra charges here as well.
…//github.com/Dzhuneyt/aws-cdk into dzhuneyt/issue-19346-ec2-detailed-monitoring
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#19346 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #19346
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license