feat(synthetics): add support for puppeteer 3.4 runtime#19429
feat(synthetics): add support for puppeteer 3.4 runtime#19429mergify[bot] merged 8 commits intoaws:masterfrom
Conversation
|
|
| runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_3, | ||
| }); | ||
|
|
||
| new synthetics.Canary(stack, 'MyCanaryFour', { |
There was a problem hiding this comment.
if you change an integ test you are going to have to update the corresponding expected.json file by running yarn integ -t integ.canary.js. But i don't think we need that for such a small change. i prefer if you just remove the changes to the integ test.
There was a problem hiding this comment.
prefer if you just remove the changes to the integ test.
Removed in 90c89a4
Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>
kaizencc
left a comment
There was a problem hiding this comment.
Build is still failing. I suggest you run ../../../scripts/buildup in the aws-synthetics folder to ensure that it's going to build. I'm going to mark this as exempt-test because we really don't need to test this.
| code: synthetics.Code.fromInline('/* Synthetics handler code */'), | ||
| }), | ||
| runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_3, | ||
| runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_4, |
There was a problem hiding this comment.
I'd rather not change this. Since we're not testing for runtime, it doesn't matter what we change in this field.
And revert the test change.
|
@kaizen3031593 i think this is good now. Thanks for your quick feedback! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #19382 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes #19382
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license