Skip to content

chore: update autolabeler keywords for alpha packages#19410

Merged
mergify[bot] merged 5 commits intomasterfrom
peterwoodworth/automationUpdate
Mar 18, 2022
Merged

chore: update autolabeler keywords for alpha packages#19410
mergify[bot] merged 5 commits intomasterfrom
peterwoodworth/automationUpdate

Conversation

@peterwoodworth
Copy link
Copy Markdown
Contributor

@peterwoodworth peterwoodworth commented Mar 16, 2022

So that customers titling issues with the -alpha suffix on alpha packages get triaged properly

Uses new affixes feature


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 16, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 16, 2022
@peterwoodworth peterwoodworth added the pr/do-not-merge This PR should not be merged at this time. label Mar 16, 2022
@peterwoodworth
Copy link
Copy Markdown
Contributor Author

Do not merge until aws-github-ops/aws-issue-triage-manager#22 is merged

@peterwoodworth peterwoodworth removed the pr/do-not-merge This PR should not be merged at this time. label Mar 17, 2022
NGL321
NGL321 previously requested changes Mar 17, 2022
Copy link
Copy Markdown
Contributor

@NGL321 NGL321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments on the keywords I think should be kept explicitly

@peterwoodworth peterwoodworth requested a review from NGL321 March 17, 2022 21:50
{"area":"@aws-cdk/aws-aps","keywords":["aps","aws-aps","prometheus"],"labels":["@aws-cdk/aws-aps"],"assignees":["corymhall"]},
{"area":"@aws-cdk/triggers","keywords":["trigger","aws-cdk/triggers","triggers"],"labels":["@aws-cdk/triggers"],"assignees":["otaviomacedo"]}
{"area":"@aws-cdk/triggers","keywords":["trigger","triggers"],"labels":["@aws-cdk/triggers"],"assignees":["otaviomacedo"]}
]
Copy link
Copy Markdown
Contributor

@ryparker ryparker Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sound to me. However this is all pretty hard to read. Would you consider using some JSON formatting in these files? Something like prettier? 🤔

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d3e3c36
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b601d67 into master Mar 18, 2022
@mergify mergify bot deleted the peterwoodworth/automationUpdate branch March 18, 2022 14:15
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants