feat: attach affixes to each keyword#22
Merged
peterwoodworth merged 6 commits intomainfrom Mar 17, 2022
Merged
Conversation
NGL321
approved these changes
Mar 16, 2022
Contributor
NGL321
left a comment
There was a problem hiding this comment.
Affixes implementation seems really useful! The code is generally clean and consistent. The simplification and extraction of reused code is also a solid improvement. There are one or two simple syntax suggestions, but this is just about ready, so feel free to accept the suggestions or merge as-is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For much easier configuring and maintaining of templates, especially larger ones
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license