chore(cli): reorganize CLI code#19324
Merged
mergify[bot] merged 6 commits intomasterfrom Mar 17, 2022
Merged
Conversation
Reorganize CLI code so that the `aws-auth` and `plugin` directories can be (mostly) airlifted out. Any dependencies it has on surrounding code is encoded in the `_env.ts` source file, which will do foreign imports. The plugin subsystem used to call the context provider subsystem directly--that's now inverted so that you don't have to lift the context provider system out with it.
|
|
iliapolo
approved these changes
Mar 14, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
pushed a commit
that referenced
this pull request
Mar 17, 2022
Reorganize CLI code so that the `aws-auth` and `plugin` directories can be (mostly) airlifted out. Any dependencies it has on surrounding code is encoded in the `_env.ts` source file, which will do foreign imports. The plugin subsystem used to call the context provider subsystem directly--that's now inverted so that you don't have to lift the context provider system out with it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize CLI code so that the
aws-authandplugindirectories canbe (mostly) airlifted out. Any dependencies it has on surrounding code
is encoded in the
_env.tssource file, which will do foreign imports.The plugin subsystem used to call the context provider subsystem
directly--that's now inverted so that you don't have to lift the context
provider system out with it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license