feat(eks): Service Account names validation#19251
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Mar 7, 2022
Merged
Conversation
Kubernetes has got specific requirements to names of resources: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/ Without checks user will learn about invalid name at `cdk deploy` stage. That could leave EKS cluster in an inconsistent state. fixes aws#18189
|
|
2 tasks
otaviomacedo
approved these changes
Mar 7, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
Kubernetes has got specific requirements to names of resources: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/ Without checks user will learn about invalid name at `cdk deploy` stage. That could leave EKS cluster in an inconsistent state. fixes aws#18189 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes has got specific requirements to names of resources:
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
Without checks user will learn about invalid name at
cdk deploystage.That could leave EKS cluster in an inconsistent state.
fixes #18189
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license